Skip to content

feat(deploy)!: option to require approval for deployment builds#1430

Open
ecrupper wants to merge 1 commit intomainfrom
feat/deploy-approval
Open

feat(deploy)!: option to require approval for deployment builds#1430
ecrupper wants to merge 1 commit intomainfrom
feat/deploy-approval

Conversation

@ecrupper
Copy link
Copy Markdown
Contributor

@ecrupper ecrupper commented Apr 3, 2026

This feature empowers projects to lean on deployment strategies without bypassing any sort of approval process, preventing solo actors from kicking off important builds. It also serves as a "final check" of sorts before running deployments to ensure the pipeline is compiled the way the user intends.

@ecrupper ecrupper requested a review from a team as a code owner April 3, 2026 16:04
@ecrupper ecrupper added the v0.29 label Apr 3, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.08%. Comparing base (3b28752) to head (7a97672).

Files with missing lines Patch % Lines
api/build/enqueue.go 0.00% 2 Missing ⚠️
api/repo/create.go 0.00% 2 Missing ⚠️
api/repo/update.go 0.00% 2 Missing ⚠️
database/testutils/api_resources.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1430   +/-   ##
=======================================
  Coverage   58.08%   58.08%           
=======================================
  Files         663      663           
  Lines       25508    25528   +20     
=======================================
+ Hits        14816    14829   +13     
- Misses       9995    10002    +7     
  Partials      697      697           
Files with missing lines Coverage Δ
api/types/repo.go 98.05% <100.00%> (+0.07%) ⬆️
database/repo/table.go 100.00% <ø> (ø)
database/types/repo.go 86.25% <100.00%> (+0.21%) ⬆️
mock/server/repo.go 0.00% <ø> (ø)
database/testutils/api_resources.go 0.00% <0.00%> (ø)
api/build/enqueue.go 0.00% <0.00%> (ø)
api/repo/create.go 0.00% <0.00%> (ø)
api/repo/update.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant